Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat implement whatsapp with vonage bun #252

Merged

Conversation

parthj000
Copy link
Contributor

@parthj000 parthj000 commented Oct 31, 2023

hey @gewenyu99 @Haimantika @loks0n , i have raised the PR please review it !!

This is a video demonstrating the bun whatsapp bot with vonagee-api

video_demo.mp4

@parthj000
Copy link
Contributor Author

image

Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I see a few issues.

  1. you've nested this under bun/starter, which is not entirely correct
  2. You've created a standalone express server, this should be an Appwrite Function

Thanks!

bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/starter/whatsapp-with-vonage/src/main.js Outdated Show resolved Hide resolved
@parthj000 parthj000 requested a review from loks0n November 7, 2023 12:40
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I'm spending a lot of time going back and forth with this PR - please try to address all my comments before resubmitting for review.

bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
@parthj000 parthj000 requested a review from loks0n November 9, 2023 23:48
bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Show resolved Hide resolved
@parthj000
Copy link
Contributor Author

@loks0n , but what will happen to the event webhook ,If I remove this then incoming event webhooks will not be addressed and in documentation it is written that the webhook must be responded with 2XX response and if not done the request will be retried ... so will it not cause any problem and is it efficient to not account the webhooks giving us the status of message ?
And I have removed "text" as a parameter from the throwIfMissing function .

Documentation -https://developer.vonage.com/en/api/messages-olympus#websockets

@parthj000
Copy link
Contributor Author

Please review this ! @loks0n

bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/README.md Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/static/index.html Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
bun/whatsapp-with-vonage/src/utils.ts Outdated Show resolved Hide resolved
@parthj000
Copy link
Contributor Author

parthj000 commented Nov 16, 2023

@loks0n updated !

bun/whatsapp-with-vonage/src/main.ts Outdated Show resolved Hide resolved
@loks0n loks0n merged commit 46aaa17 into appwrite:main Nov 16, 2023
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@parthj000
Copy link
Contributor Author

@gewenyu99 ,
pars0942

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@parthj000
Copy link
Contributor Author

Hey , @gewenyu99, I have not been contacted for the swags yet :)

@adityaoberai
Copy link
Member

@gewenyu99 , pars0942

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.
Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Hey Parth
Just sent you a friend request on DIscord. If you can accept it and DM me, I'll send over the form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add WhatsApp with Vonage for Bun
4 participants