Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pdf generate in python #217

Closed
wants to merge 1 commit into from

Conversation

aryabyte21
Copy link

What does this PR do?

Generate PDF Template for python

Test Plan

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file to README.md

Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you provide a video showing the function working.

Please note this contribution will not count towards hacktoberfest as it does not have a requisite issue.

# with open("output.pdf", "wb") as f:
# f.write(pdf_buffer)

return pdf_buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, we need to use res.send() with the requisite headers. Please see examples of the template in other runtimes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it!


No environment variables required.

> Note: Ensure you have a `requirements.txt` file in the project directory containing all the necessary packages (like `Faker`, `pdfkit`, etc.).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we provide this we don't need this line :)

@loks0n
Copy link
Member

loks0n commented Oct 6, 2023

Can you also please create a relevant issue for this?

@loks0n
Copy link
Member

loks0n commented Oct 23, 2023

Closing as we don't have a relevant issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants