Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enum Whitelist #674

Merged
merged 56 commits into from
Aug 15, 2023
Merged

feat: Enum Whitelist #674

merged 56 commits into from
Aug 15, 2023

Conversation

2002Bishwajeet
Copy link
Contributor

What does this PR do?

Generates enum for the given whitelist

Test Plan

N/A

Related PRs and Issues

Part of #426

Have you read the Contributing Guidelines on issues?

yess

@2002Bishwajeet 2002Bishwajeet marked this pull request as draft June 19, 2023 12:30
@2002Bishwajeet 2002Bishwajeet marked this pull request as ready for review July 12, 2023 11:42
eldadfux
eldadfux reviewed Jul 12, 2023
View reviewed changes
src/SDK/Language.php Outdated Show resolved Hide resolved
src/SDK/SDK.php Show resolved Hide resolved
src/Spec/Swagger2.php Outdated Show resolved Hide resolved
templates/dart/lib/enums.dart.twig Outdated Show resolved Hide resolved
christyjacob4
christyjacob4 reviewed Jul 13, 2023
View reviewed changes
src/SDK/SDK.php Outdated Show resolved Hide resolved
lohanidamodar
lohanidamodar requested changes Jul 16, 2023
View reviewed changes
templates/dart/lib/enums.dart.twig Outdated Show resolved Hide resolved
2002Bishwajeet
2002Bishwajeet commented Jul 17, 2023
View reviewed changes
Copy link
Contributor Author

@2002Bishwajeet 2002Bishwajeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one minor change

src/SDK/Language/DotNet.php Outdated Show resolved Hide resolved
@abnegate
Copy link
Contributor

@2002Bishwajeet We still need to change the service function parameters types to the enum type where applicable

E.g. Here the provider param should be typed Provider instead of string

@lohanidamodar lohanidamodar changed the base branch from master to 1.4.x August 4, 2023 13:44
adityaoberai
adityaoberai requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2002Bishwajeet add a couple of comments

templates/dotnet/src/Appwrite/Enums/Enums.cs.twig Outdated Show resolved Hide resolved
templates/dotnet/src/Appwrite/Enums/Enums.cs.twig Outdated Show resolved Hide resolved
adityaoberai
adityaoberai requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2002Bishwajeet one more comment

templates/dotnet/src/Appwrite/Enums/Enums.cs.twig Outdated Show resolved Hide resolved
@abnegate abnegate changed the base branch from 1.4.x to feat-whitelist-enums August 15, 2023 18:50
@abnegate abnegate merged commit 8004657 into appwrite:feat-whitelist-enums Aug 15, 2023
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux left review comments

@abnegate abnegate abnegate approved these changes

@lohanidamodar lohanidamodar lohanidamodar approved these changes

@adityaoberai adityaoberai adityaoberai approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@2002Bishwajeet @abnegate @eldadfux @lohanidamodar @christyjacob4 @adityaoberai @Meldiron