Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added type hints for Python SDK #665

Merged
merged 1 commit into from
Jul 4, 2023
Merged

refactor: added type hints for Python SDK #665

merged 1 commit into from
Jul 4, 2023

Conversation

Ananya2001-an
Copy link

What does this PR do?

Added type hints for better readability and maintainability. It's added only for a few methods at the moment but can improve on that later on... :)

Related PRs and Issues

With reference to issue: appwrite/sdk-for-python#43

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90
Copy link
Contributor

@lohanidamodar, I think we should merge this and iterate upon it to add even more.

@lohanidamodar
Copy link
Member

Thanks @stnguyen90.
@abnegate would love to hear your thoughts as well.

@abnegate
Copy link
Contributor

abnegate commented Jun 28, 2023

@abnegate would love to hear your thoughts as well.

@lohanidamodar I think we should do this for all templates at once, the service methods would benefit most from this

@lohanidamodar
Copy link
Member

@Ananya2001-an would you like to continue further to add type hints for the remaining parts? If not I'll merge your PR into a separate branch so that our team can work on top of it. Let me know ho you would like to proceed.

@Ananya2001-an
Copy link
Author

Hey @lohanidamodar I would love to continue working on it....later on you can merge it to a separate branch when I have done the final changes according to me :)

@Ananya2001-an
Copy link
Author

Hey, I think you can merge this for now since I am not sure where to add type hints further :)

@lohanidamodar
Copy link
Member

@Ananya2001-an not a problem. Thank you for your contribution

@lohanidamodar lohanidamodar changed the base branch from master to feat-python-type-hints July 4, 2023 07:22
@lohanidamodar lohanidamodar merged commit 4dcded2 into appwrite:feat-python-type-hints Jul 4, 2023
1 of 2 checks passed
@Ananya2001-an Ananya2001-an deleted the refactor-python-add-type-hints branch July 4, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants