Refactor dotnet generation #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide API Error Answer class - Use System.Text.Json instead of Newtonsoft.Json - Avoid dependency from Microsoft.CSharp - Build only netstandard2.0
- Use C# type double for PHP type number
- Use nullable
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor/improve the Dotnet SDK generation:
doublefor PHP typenumberTest Plan
Without the change to use
doubletype it's not possible to build the project since the PHP typenumberwas not included in the switch case when getting the type.The project now builds and makes use of nullable types for non-mandatory fields.
Related PRs and Issues
Currently available versions on NuGet are not updated/aligned with the latest versions of Appwrite. For example the User ID is now (I didn't check since when) mandatory for user creation but not required from the published SDK
Have you read the Contributing Guidelines on issues?
Yup, I did. I hope to comply to all the instructions by the end of the PR
[1] compatibility starting from .Net Framework 4.6.1 that is the minimun non-EOL version (https://learn.microsoft.com/en-us/lifecycle/products/microsoft-net-framework)
[2] requires C# 8.0, provided with .Net Core 3.0 installation