Adding Scoop support #450
Adding Scoop support #450
Conversation
CEbbinghaus
force-pushed
the
feature/addingScoop
branch
from
426cc36
to
9c3c02e
Compare
|
Install can be tested with this command: $ scoop install https://gist.githubusercontent.com/CEbbinghaus/3219a010325e9684839f7ce5ecea4afd/raw/2f19d33dc4581658d5e73edda4d763644129621a/appwrite.jsonGenerated with the SDK |
|
The build task seems to be failing because of Docker rate limits not the changes I added |
Restarted failed jobs. All green now 💚 |
|
Sweet. This PR is ready to merge then as it shouldn't contain any extra changes. It's going to be the prerequisite for the other changes so i am very keen to get it merged asap |
|
Requesting another review as its still not merged and the merging is blocked. It might be smart to leave it until ScoopInstaller/Scoop#3146 is merged as it would allow for the ARM release to be installed too |
|
@Meldiron looks like the blocking issue was merged can you help move forward with this? |
|
Thanks @lohanidamodar, since opening this PR I have learned a lot about scoop & how it works. There are some small modifications I want to do to it as it stands right now since it would require a PullRequest to the scroop repository for every version which is not desired. Instead if we can generate the Appwrite.json file a little differently, it should auto update within the scoop repository. That means that the changes will be lagging behind until scoop's main bucket does another update cycle but that is probably faster than waiting for a human review of every version. |
There was a problem hiding this comment.
Not quite ready to be merged. Will try and get these changes in today to bring it up to date. Also of note is that this will generate the json file every single version but only 1 will ever be committed to the main bucket scoop maintains as it self updates the json through the "checkver" property.
|
@CEbbinghaus thank you for your immediate response. Please make the necessary changes and request another review. |
CEbbinghaus
force-pushed
the
feature/addingScoop
branch
from
610664c
to
9c3c02e
Compare
CEbbinghaus
force-pushed
the
feature/addingScoop
branch
from
9c3c02e
to
a3a128e
Compare
|
@lohanidamodar who should I request the review from? |
Co-authored-by: Steven <[email protected]>
|
So this is ready to merge? The failed Travis build seems to be more of an amnesty rather than due to my changes. Is anything hold it up? |
There was a problem hiding this comment.
So this is ready to merge? The failed Travis build seems to be more of an amnesty rather than due to my changes. Is anything hold it up?
@CEbbinghaus would you please update this branch with the latest from master? There may be something on master that will fix the CI.
|
Updated with the latest from master. Lets hope it fixes the CI task :3 Edit: Seems that is the case. Should be good to merge. |
|
How do we trigger a run for the CLI SDK so it updates the content & generates the files. Once that is complete I can create the PR to merge appwrite into the main scoop bucket which I can add back into the docs so you merely run |
This PR is to add scoop support to the CLI install.
With first a github hosted uri to install it manually:
and hopefully the ability for scoop to verify hashes as well as install it via the main bucket
which will require a working autoupdater and working version check
This PR implements Feature appwrite/sdk-for-cli/issues/39