File Tokens RFC #58
Open
File Tokens RFC #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2023
2 tasks
eldadfux
reviewed
Aug 24, 2023
|
|
||
| <!-- Brief explanation of the proposed contribution. Write your answer below. --> | ||
|
|
||
| Accessing files currently requires either files to be public or need user session with user that have access permission. It's mainly painful for image previews that we want to show publicly. For this reason, we want to introduce file tokens. The tokens will be linked to specific file and will be passed in URL for previews and downloads to provide access. |
There was a problem hiding this comment.
We could also mention how this is problematic with some browsers that don't supports Appwrite's secure cookies.
024-file-tokens.md
Outdated
| Avoid using 3rd party libraries when possible, if required - explain why. | ||
| --> | ||
|
|
||
| This particular feature doesn't require any supporting libraries. |
There was a problem hiding this comment.
We might need to use JWT tokens for validating the tokens and their permissions. This is because we might not be able to access our DB for validation when serving cached images.
There was a problem hiding this comment.
Not sure I understand completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)