Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --p-icon-size to 0.65 to make the fix the icon alignment #93

Closed
wants to merge 3 commits into from

Conversation

Emiltayeb
Copy link

What does this PR do?

Fixing the icon size of the switch input being used in the auth section of the console

Before:
image

After:
image

Have you read the Contributing Guidelines on issues?

(Write your answer here.)
yes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

⚠️ No Changeset found

Latest commit: fbc8252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pink-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 10:28am
ui-kitchensink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 10:28am

Copy link

@PulkitBxtra PulkitBxtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 8 appears to be in good shape and meets the required standards. However, I find the presence of an additional tab character on line 132 seems to be unnecessary.

@Emiltayeb
Copy link
Author

Line 8 appears to be in good shape and meets the required standards. However, I find the presence of an additional tab character on line 132 seems to be unnecessary.

fixing

Line 8 appears to be in good shape and meets the required standards. However, I find the presence of an additional tab character on line 132 seems to be unnecessary.

Fixed :)

@TorstenDittmann
Copy link
Contributor

The arrow was actually a bug and got removed completely, so this PR is not needed anymore.

Still thank you for your work 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants