Implement DSN Connection Strings Support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb73edb
to
d7ad1d6
Compare
This PR introduces support for DSN connection strings to simplify the configuration process. Users can now use a single string to determine the type of connection (`Network` or `Pipe`) and its details. This PR resolves appwrite#28, closes appwrite#25, resolves appwrite#26, closes appwrite#27, closes appwrite#31 1. Added a static `createFromDSN` method to the `ClamAV` abstract class. This method parses the provided DSN string and returns an appropriate instance (`Network` or `Pipe`). 2. Updated the `ClamAVTest` unit test to cover the new DSN creation functionality. 3. Updated composer dependencies 4. Applied smaller code, and documentation optimizations 5. Improved code coverage 6. Updated README Users can now initialize a connection using a DSN string: ```php $clam = ClamAV::createFromDSN('tcp:https://localhost:3310'); $version = $clam->version(); ``` This approach provides a more flexible and user-friendly way to set up a connection. The existing unit tests have been updated accordingly.
d7ad1d6
to
278d8a9
Compare
tomboe311
approved these changes
Jun 17, 2024
tomboe311
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for DSN connection strings to simplify the configuration process. Users can now use a single string to determine the type of connection (
NetworkorPipe) and its details.This PR resolves #28, closes #25, resolves #26, closes #27, closes #31
Changes:
createFromDSNmethod to theClamAVabstract class. This method parses the provided DSN string and returns an appropriate instance (NetworkorPipe).ClamAVTestunit test to cover the new DSN creation functionality.Usage:
Users can now initialize a connection using a DSN string:
This approach provides a more flexible and user-friendly way to set up a connection.
Testing:
Existing unit tests have been updated accordingly.