Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Update getting-started-for-flutter.phtml #372

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

lohanidamodar
Copy link
Member

What does this PR do?

  • mention minimum macOS version

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

YES

@stnguyen90 stnguyen90 self-requested a review May 21, 2023 01:46
@@ -70,6 +70,7 @@ $version = (isset($versions['flutter'])) ? $versions['flutter'] : '';
<h3><a href="/docs/getting-started-for-flutter#macOS" id="macOS">Mac OS</a></h3>

<p>For <b>Mac OS</b> add your app name and Bundle ID, You can find your Bundle Identifier in the General tab for your app's primary target in Xcode.</p>
<p>The Appwrite SDK uses ASWebAuthenticationSession on macOS 10.15+ to allow OAuth authentication. You have to change your macOS Deployment Target in Xcode to be macOS >= 10.15 to be able to build your app for macOS.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use MacOS Mac OS or macOS? What's the official format? let's pick one and stick to it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Its macOS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay,let's update all occurences of Mac OS and MacOS to macOS. Just so we're consistent.

Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all of this :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants