Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip location wrong #981

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Tooltip location wrong #981

wants to merge 10 commits into from
+14 −13

Conversation

elad2412
Copy link
Contributor

  • Add fix that element will not get full-line and fill fit is content

@elad2412
Tooltip location wrong
94f6224 
- Add fix that element will not get full-line, and fill wit is content
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 4:51am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 4:51am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 4:51am

stnguyen90
stnguyen90 requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run fromat to fix the lint issue.

stnguyen90
stnguyen90 requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch is 160 commits behind main and there are some bugs with it. Please update your branch and run the formatter (npm run format) to fix the lint issues.

@stnguyen90
Copy link
Contributor

stnguyen90 commented Apr 30, 2024 •
edited
Loading

Some tooltips are not working. It seems only the cells with more than 125 chars work.

image

Also, the table doesn't scroll anymore. Is that the intended behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 requested changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

@eldadfux eldadfux Awaiting requested review from eldadfux

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elad2412 @stnguyen90