Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide modal on error #970

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sourabpramanik
Copy link
Contributor

What does this PR do?

This PR is to hide the send modal in the Message page if there is an error in sending a message

Test Plan

Manual

Related PRs and Issues

Fixes: #965

Have you read the Contributing Guidelines on issues?

YES

Copy link

vercel bot commented Mar 16, 2024

@sourabpramanik is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@ItzNotABug
Copy link
Contributor

Not sure if this Issue / PR was assigned but as per the linked issue, even the scheduleModal.svelte requires this fix.

Thanks.

@stnguyen90
Copy link
Contributor

@sourabpramanik, please make sure you ask to be assigned on the issue so that we can assign the issue to you and no one else tries to work on the issue.

And as @ItzNotABug said, the schedule modal also needs to be fixed.

@sourabpramanik
Copy link
Contributor Author

@sourabpramanik, please make sure you ask to be assigned on the issue so that we can assign the issue to you and no one else tries to work on the issue.

And as @ItzNotABug said, the schedule modal also needs to be fixed.

Really sorry about that, I will be careful next time. I will take a look at the schedule modal as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Send Message Modal Not Dismissed
3 participants