Add messaging providers route #602
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4de6350
to
383a71f
Compare
| { id: 'status', title: 'Status', show: true } | ||
| ]); | ||
|
|
||
| export const providers = { |
There was a problem hiding this comment.
@TorstenDittmann, what do you think about having this JSON for the wizard for all providers. I wanted to try and minimize the number of places you'd need to go if we add a messaging provider in the future.
There was a problem hiding this comment.
Torsten: for now, let's continue with this.
| try { | ||
| let response = { $id: '', name: '' }; | ||
| const providerId = $providerParams[$provider].providerId || ID.unique(); | ||
| switch ($provider) { |
There was a problem hiding this comment.
@TorstenDittmann, this is going to be long and annoying because there's a different method for each provider. Any thoughts on how to improve this?
There was a problem hiding this comment.
Torsten: for now, let's go with this.
| export const providerParams = writable<{ mailgun: Partial<MailgunProviderParams> }>({ | ||
| mailgun: null | ||
| }); |
There was a problem hiding this comment.
@TorstenDittmann, I wanted to do this to make the create/update part easier, but do you think it's not worth it and I should just have a writable for each provider?
There was a problem hiding this comment.
Torsten: for now, let's go with this.
383a71f
to
8a954c6
Compare
8a954c6
to
517c609
Compare
f3c7f46
to
f3f10c8
Compare
4ad42f9
to
20bc5f7
Compare
f3f10c8
to
ad2beae
Compare
20bc5f7
to
a99082e
Compare
ad2beae
to
ae8da6a
Compare
src/routes/console/project-[project]/messaging/providers/provider-[provider]/+layout.ts
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/messaging/providers/update.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/messaging/providers/wizard/configure.svelte
Outdated
Show resolved
Hide resolved
…d/configure.svelte
…der-[provider]/+layout.ts
What does this PR do?
Add messaging providers route
Test Plan
TBD
Related PRs and Issues
Parent:
Children:
Have you read the Contributing Guidelines on issues?
Yes