Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom copy for google oauth provider #453

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

gewenyu99
Copy link

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@gewenyu99 gewenyu99 requested a review from ArmanNik May 24, 2023 16:00
@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 5:58pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 5:58pm

@gewenyu99
Copy link
Author

Screenshot 2023-05-24 at 12 10 03 PM I think the only thing that's different is `... and select web application as the application type.`

@gewenyu99 gewenyu99 marked this pull request as ready for review May 24, 2023 16:11
Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewenyu99 I might have missed it but how is this component different from the mainOAuth component that is the default for all oauths?

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewenyu99 I might have missed it but how is this component different from the mainOAuth component that is the default for all oauths?

@gewenyu99
Copy link
Author

@gewenyu99 I might have missed it but how is this component different from the mainOAuth component that is the default for all oauths?

@ArmanNik We need to mention that they need to create OAuth as a web app even for mobile and flutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants