Prevent footer from covering dropdown #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The z-index was set to 20 to prevent the language indicator for code sample from showing, but this caused other things to be hidden. Since the language tag has a z-index of 2, we can make the footer have a z-index of 5 so it covers the language tag, but doesn't cover a dropdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TorstenDittmann
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The z-index was set to 20 to prevent the language indicator for code sample from showing, but this caused other things to be hidden.
Since the language tag has a z-index of 2, we can make the footer have a z-index of 5 so it covers the language tag, but doesn't cover a dropdown
Fixes #1249
Test Plan
Manually checked dropdown:
Manually checked language tag:
Related PRs and Issues
Related issue:
Previous issue:
Have you read the Contributing Guidelines on issues?
Yes