Feat new session alert #8315
Merged
Feat new session alert #8315
+236
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-new-session-alert
byawitz
approved these changes
Jun 27, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
approved these changes
Jul 2, 2024
vermakhushboo
approved these changes
Jul 2, 2024
abnegate
reviewed
Jul 3, 2024
app/controllers/api/projects.php
Outdated
| ->label('sdk.response.type', Response::CONTENT_TYPE_JSON) | ||
| ->label('sdk.response.model', Response::MODEL_PROJECT) | ||
| ->param('projectId', '', new UID(), 'Project unique ID.') | ||
| ->param('sessionAlerts', false, new Boolean(true), 'Set to true to enable session emails.') |
There was a problem hiding this comment.
enabled might be a better name here, since the scope is already session alerts
There was a problem hiding this comment.
I looked the same direction, but in other endpoints we do this too. like updateAuthLimit(limit) or updateAuthDuration(duration) or updateAuthStatus(status).
If you are against this pattern, we can make task in 1.6 QA board and discuss, but for now lets follow what is there.
With that in mind, I am changing it from updateSessionAlerts(sessionAlerts) to updateSessionAlerts(alerts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.