Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 1.5.x into refactor-usage-sn #8244

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Sync 1.5.x into refactor-usage-sn #8244

merged 7 commits into from
Jun 10, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jun 7, 2024

What does this PR do?

Sync to bump the base image via #8238

Test Plan

CI should pass

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

stnguyen90 and others added 7 commits May 29, 2024 13:59
Bump base image from 0.9.0 to 0.9.1
Before this, users who only signed in with OAuth2 were not able to
verify their sessions with MFA because their session already used an
email factor and they couldn't use an additional email factor.

This commit changes the OAuth2 session to include 2 factors: email and
oauth2. This second special factor is used to bypass MFA checks. It is
fine to bypass MFA checks because OAuth2 is supposed to handle the
entire authentication process, verifying who the user is and we, as the
resource provider, only need to trust the OAuth2 provider.
Fix MFA for OAuth2 only accounts
@stnguyen90 stnguyen90 marked this pull request as ready for review June 9, 2024 21:35
@abnegate abnegate merged commit 3c123d3 into refactor-usage-sn Jun 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants