Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #8237 from appwrite/revert-8193-feat-remov… #8240

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Revert "Merge pull request #8237 from appwrite/revert-8193-feat-remov… #8240

merged 3 commits into from
Jun 7, 2024

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Jun 6, 2024

What does this PR do?

Revert the revert of removal of random shared tables

  • Remove random assignment of projects to shared tables
  • Use environment variable for setting shared tables db
  • Run all tests using both shared and non-shared tables

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@abnegate abnegate merged commit 7e3070a into refactor-usage-sn Jun 7, 2024
21 checks passed
@abnegate abnegate deleted the revert-8237-revert-8193-feat-remove-random-shared-tables branch June 7, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abnegate @christyjacob4