Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Expired Targets Per Project #8239

Merged

Conversation

ItzNotABug
Copy link
Contributor

@ItzNotABug ItzNotABug commented Jun 6, 2024

What does this PR do?

Deletes the expired messaging targets per project.

Fixes #8159

Test Plan

N/A.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 self-requested a review June 8, 2024 00:21
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Would you be able to provide some screenshot of maybe logs or something to verify this does fix the problem?

@ItzNotABug
Copy link
Contributor Author

ItzNotABug commented Jun 9, 2024

Before (expired and active targets) -

Screenshot 2024-06-09 at 7 34 20 PM

 
Ran - docker exec appwrite maintenance

After -

Screenshot 2024-06-09 at 7 37 06 PM

Update - I tried with the current logic as well, that seemed to remove the expired targets even when not run per project.

@stnguyen90, What do you think?

@stnguyen90
Copy link
Contributor

Update - I tried with the current logic as well, that seemed to remove the expired targets even when not run per project.

@ItzNotABug you mean before your change? It could be because the project is set after the loop and so the delete expired works, but only for that last project.

@ItzNotABug
Copy link
Contributor Author

@stnguyen90 Had the same idea after I realized that there was only one project added. Thanks for the confirmation!

@stnguyen90 stnguyen90 merged commit 0376189 into appwrite:main Jun 11, 2024
23 checks passed
@ItzNotABug ItzNotABug deleted the 8159-delete-expired-targets-per-project branch June 11, 2024 15:49
@stnguyen90 stnguyen90 mentioned this pull request Jun 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Expired targets not automatically deleted
2 participants