Feat Sync team deletion #8217
Feat Sync team deletion #8217
Conversation
byawitz
added
the
product / auth
|
@Meldiron, checked, the test is without |
|
The test returns 404, which means the teams were deleted, and there's no way to delete them in an async way. What should the test be different? |
Even without your change, the current test returns 404 so the current test doesn't actually test anything about memberships?
A test that verifies the memberships are deleted would be great. I'm not totally sure on how to test, though. Maybe users.listMemberships()? |
|
The tests check if the team for a given ID exists. When the endpoint returns Do you mean to add a whole new test for |
There was a problem hiding this comment.
Do you mean to add a whole new test for userMemberships
@byawitz, something like that. The goal is to test and make sure the memberships are deleted when the team is deleted.
|
Test added here |
| ->inject('dbForProject') | ||
| ->inject('queueForEvents') | ||
| ->inject('dbForConsole') |
There was a problem hiding this comment.
dbForConsole isn't needed anymore, right?
| @@ -76,6 +76,7 @@ services: | |||
| - appwrite-config:/storage/config:rw | |||
| - appwrite-certificates:/storage/certificates:rw | |||
| - appwrite-functions:/storage/functions:rw | |||
| - appwrite-builds:/storage/builds:rw | |||
| @@ -65,6 +65,7 @@ $image = $this->getParam('image', ''); | |||
| - appwrite-config:/storage/config:rw | |||
| - appwrite-certificates:/storage/certificates:rw | |||
| - appwrite-functions:/storage/functions:rw | |||
| - appwrite-builds:/storage/builds:rw | |||
What does this PR do?
Changed team and organization deleting logic to the API instead of queuing it to the deleting worker
Test Plan
Tested against local
1.5.5instance,Related PRs and Issues
Close #7939
Checklist