-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade logger and add fallback calculation #8145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fuyangpengqi <[email protected]>
feature-5232-Security-Scans-OSV-Scanner
This workflow action uses OSV Scanner, an open source vulnerability scanner by Google. We're using OSV Scanner because it has: * good usability - JSON output and multiple options * good accuracy - OSV database from google and support for multiple languages including PHP
Due to failures, changing to not_planned
Fix stale action close reason
Add OSV Scanner for vulnerability scans
chore: fix some typos in comments
…rying-deployments Fix: Use `resourceInternalId` for Querying Function Deployments
…adme Replace missing domain paths in README.md
Prevent functions domain to be used as custom domain
…d-consosud-to-cencosud
Fix: Email OTP verified account
…-from-censosud-and-consosud-to-cencosud fix: updated typo in credit-cards.php credit card image filename
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Co-authored-by: Christy Jacob <[email protected]>
Feat create new metric explanation
…n-warning-at-appwrite-doctor Fix Deprecated Warning in Doctor.php
…ocale-endpoint-Palestine Add new country Palestine with its translations
Improve container naming conventions
@@ -732,6 +732,16 @@ function (mixed $value) { | |||
throw new Exception(Exception::GENERAL_SERVER_ERROR, "Logging provider not supported. Logging is disabled"); | |||
} | |||
|
|||
// Old Sentry Format conversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Old Sentry Format conversion | |
// Old Sentry Format conversion. Fallback until the old syntax is completely deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the logger and adds a fallback calculation for older env-var types as to not break compatibility.
Test Plan
Test with both new and old type, both work
Checklist