Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose function timeout variable to console #7794

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ArmanNik
Copy link
Member

@ArmanNik ArmanNik commented Mar 11, 2024

What does this PR do?

  • Add funciton timeout env variable to the /v1/console/variables endpoint

Test Plan

Manual

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ArmanNik ArmanNik self-assigned this Mar 11, 2024
@stnguyen90 stnguyen90 self-requested a review June 5, 2024 20:47
@@ -28,6 +28,7 @@ public function testGetVariables(): void
$this->assertIsString($response['body']['_APP_DOMAIN_TARGET']);
$this->assertIsInt($response['body']['_APP_STORAGE_LIMIT']);
$this->assertIsInt($response['body']['_APP_FUNCTIONS_SIZE_LIMIT']);
$this->assertIsInt($response['body']['_APP_FUNCTIONS_TIMEOUT']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The count a few lines above this also needs to be updated.

@stnguyen90 stnguyen90 marked this pull request as draft June 17, 2024 23:02
auto-merge was automatically disabled June 17, 2024 23:02

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants