Added cancel build endpoint #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Feb 18, 2024
eldadfux
added
product / functions
eldadfux
reviewed
Feb 25, 2024
eldadfux
approved these changes
Feb 25, 2024
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
Feb 28, 2024
Comment on lines
198
to
201
| $build = $dbForProject->getDocument('builds', $buildId); | ||
| if ($build->getAttribute('status') === 'cancelled') { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I see this check above, do we need to duplicate it here?
There was a problem hiding this comment.
I see duplication in other places too
There was a problem hiding this comment.
The duplication is intentional, since cancellation can happen at any stage and we should save compute by capturing it before time consuming tasks.
Meldiron
reviewed
Feb 28, 2024
Meldiron
reviewed
May 30, 2024
Meldiron
reviewed
May 30, 2024
Meldiron
reviewed
May 30, 2024
Meldiron
reviewed
May 30, 2024
|
TODO: Check how to compute duration for cancelled build |
…pwrite into feat-cancel-build-deployment
Meldiron
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an endpoint to cancel a build and kill the container.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist