Mock OTP and phone numbers #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
added
product / auth
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
Meldiron
reviewed
Jul 1, 2024
loks0n
requested changes
Jul 1, 2024
| * | ||
| * Validates if a given object represents a valid phone and OTP pair | ||
| */ | ||
| class MockNumber extends Validator |
There was a problem hiding this comment.
Is MockNumber a good name here?
For me it's not descriptive enough...
but it's a tricky one
Some ideas:
MockPhoneOTPList
MockSMSAuthConfiguration
OTPTestingConfiguration
There was a problem hiding this comment.
I agree, this validator is confusing, if we have flat parameters, we can avoid this altogether
There was a problem hiding this comment.
MockPhoneOTPList makes most sense to me
There was a problem hiding this comment.
Let's solve this with solution for improving endpoint to make the parameter granular
abnegate
reviewed
Jul 3, 2024
| * | ||
| * Validates if a given object represents a valid phone and OTP pair | ||
| */ | ||
| class MockNumber extends Validator |
There was a problem hiding this comment.
I agree, this validator is confusing, if we have flat parameters, we can avoid this altogether
lohanidamodar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist