Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5893 oauth deeplink multiple sessions #5894

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rohankm
Copy link

@rohankm rohankm commented Jul 27, 2023

What does this PR do?

The default OAuth URL is primarily utilized as a deep link on mobile applications to establish sessions. However, the current approach has a flaw as it sets the cookies on the appwrite domain. This presents an issue, particularly when two mobile apps are concurrently running on the same project, as one app's session might overwrite another's.

To rectify this, it is advisable not to include the cookies in the default success link. By doing so, a session will not be created on the browser end, enabling two apps for the same project to function independently without any session conflicts.

Test Plan

I have manually tested it with two different apps running on react native for the same project.

Related PRs and Issues

Checklist

  • [yes] Have you read the Contributing Guidelines on issues?
  • [no] If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant