Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update getting started examples for .NET SDK #5785

Merged
merged 4 commits into from
Jul 10, 2023
Merged

doc: Update getting started examples for .NET SDK #5785

merged 4 commits into from
Jul 10, 2023

Conversation

adityaoberai
Copy link
Member

@adityaoberai adityaoberai commented Jul 7, 2023 •
edited
Loading

What does this PR do?

Update the getting started example for .NET:

  • Align code to C# coding conventions
  • Add missing using directives
  • Correct playground link title

Test Plan

Related PRs and Issues

  • No

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@adityaoberai adityaoberai changed the title Update getting started examples doc: Update getting started examples for .NET SDK Jul 7, 2023
gewenyu99
gewenyu99 reviewed Jul 7, 2023
View reviewed changes
Copy link

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

christyjacob4
christyjacob4 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the sdk version in the platforms.php file ?

@adityaoberai
Copy link
Member Author

Can you also update the sdk version in the platforms.php file ?

Updated 👍

@christyjacob4
Copy link
Member

The SDK generator version also needs to be updated in the composer and composer-lock files @adityaoberai

@adityaoberai
Copy link
Member Author

@christyjacob4 updated those too

@christyjacob4 christyjacob4 merged commit a1519e2 into 1.3.x Jul 10, 2023
2 of 3 checks passed
@christyjacob4 christyjacob4 deleted the update-dotnet-getting-started branch July 11, 2023 19:59
This was referenced Aug 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewenyu99 gewenyu99 gewenyu99 left review comments

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adityaoberai @christyjacob4 @gewenyu99