Fix 3256 update document when attribute name is numeric #5723
Conversation
What's Changed?
Test Plan
|
|
@abnegate |
|
@abnegate |
|
@abnegate |
…ribute-name-is-numeric
|
@fogelito can you review this PR please. |
| @@ -3279,7 +3279,7 @@ function updateAttribute( | |||
| $permissions = $document->getPermissions() ?? []; | |||
| } | |||
|
|
|||
| $data = \array_merge($document->getArrayCopy(), $data); // Merge existing data with new data | |||
| $data = $data + $document->getArrayCopy(); // Merge existing data with new data | |||
There was a problem hiding this comment.
I think @fanatic75 solve this issue with array_merge_recursive?
There was a problem hiding this comment.
Yeah, array_merge_recursive might be worth exploring
|
|
||
| $this->assertEquals($document['body']['1'], 'one updated'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you add two more tests, please?
one for find and second for getDocument , while trying to use the select query operator for this specific attribute?
for checking validations are passed.
There was a problem hiding this comment.
@fogelito this can be solved using + operator as well although I think we should first discuss if we want to allow attribute with numeric names or not
|
@faisalill I think we have a change of plans; We will not allow attributes with numeric names. |
|
@fanatic75 imma close this PR then. |
What does this PR do?
Replaced
array_mergewith+operator.array_mergeappends the numeric keys from both the arrays and renumbers them starting from0, hence giving weird errors likeUnknown Attribute: "0". Whereas+operator uses the value from first array in the expression while retaining the same keys.Test Plan
issue3256.online-video-cutter.com.mp4
Related PRs and Issues
#3256
Checklist