Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trailing wildcards #5632

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix: trailing wildcards #5632

merged 1 commit into from
Jun 2, 2023

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Jun 2, 2023 •
edited by stnguyen90
Loading

What does this PR do?

  • implement trailing wildcards
    • fixes acme challenge
    • fixes console deep link

Fixes: #5623

Test Plan

  • manual

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@TorstenDittmann TorstenDittmann merged commit fcbd4f9 into 1.3.x Jun 2, 2023
2 checks passed
@TorstenDittmann TorstenDittmann deleted the fix-trailing-wildcard branch June 2, 2023 11:39
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TorstenDittmann @christyjacob4