Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get jwt from request param #5470

Closed
wants to merge 2 commits into from
Closed

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented May 1, 2023

What does this PR do?

  • Accept JWT also as request param ?jwt, intended for resources such as file previews and downloads

Test Plan

  • Updated relevant test to include test for JWT sent as request param

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux
Copy link
Member

eldadfux commented Jun 7, 2023

Passing or sharing a link with JWT will give full access to the user account, we should either create a limited JWT for that or go with dedicated file tokens instead.

@lohanidamodar
Copy link
Member Author

Closing this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants