-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat phone auth 360dialog #4536
Feat phone auth 360dialog #4536
Conversation
360dialog takes 4 parameters to send a message Api-key, template name, template namespace, template language. More details regarding templates can be found on https://developers.facebook.com/docs/whatsapp/api/messages/message-templates/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is AMAZING! 🤯 I've left some request for changes. Please make sure to create a PR in the Utopia Messaging library. We can leave this for later when we update Appwrite to use the Messaging library.
Hey @stnguyen90, I have made the requested changes and also added the sandbox adapter. Will add the adapter in Utopia Messaging library too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the requested changes and also added the sandbox adapter. Will add the adapter in Utopia Messaging library too.
@aakashcodess, sorry I wasn't suggesting to make edits in this PR. It might be best to close this PR and just add the new Adapters in the Utopia Messaging library.
Btw, when making your chan get in the Utopia Messaging library, make sure to have 1 Adapter subclass the other to reduce the duplicate code.
@stnguyen90 Thanks for the update. I will add new adapters in messaging library. |
Adding |
@aakashcodess thanks a lot for your contributions during Hacktoberfest 2022! Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. Also let us know if you're willing to continue working on it? |
@christyjacob4 yes, I will resume working on it this weekend. I will message you on discord to join the github org. |
@aakashcodess How's it going with this auth provider? Can we do anything to help? |
Hey @gewenyu99 , I was on break, I will start working on it. If I face any issue, I will ping you on discord. |
4d060f0
to
fd7a2cb
Compare
Hey @stnguyen90 @gewenyu99 , I wanted to finish this. I didn't had access to live 360dialog api, now i do have access to 360dialog api key, can I continue to work on this. Or i can add the adapter (twilio whatsapp and 360dialog whatsapp) in messaging library. |
What does this PR do?
This PR will add phone authentication with whatsapp using 360dialog.
Test Plan
To test you have to create a phoneSession.
To test you should have a live 360dialog api or it can be tested with 360dialog sandbox api
In .env file
_APP_SMS_PROVIDER = sms:https://template_name:api_key@dialog360
_APP_PHONE_FROM = template_namespace
Related PRs and Issues
NO
Have you added your change to the Changelog?
N0
Have you read the Contributing Guidelines on issues?
Yes