Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to match event using regex #3637

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Aug 2, 2022

What does this PR do?

Add methods to match event using regex

Test Plan

Unit tests added

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 marked this pull request as draft August 2, 2022 18:40
@eldadfux
Copy link
Member

eldadfux commented Aug 4, 2022

@stnguyen90 please provide more context about this PR and its context.

@stnguyen90
Copy link
Contributor Author

@eldadfux, this was around a discussion @TorstenDittmann and I had about whether we needed to store all variations of an event in order to process it. There was a suggestion about matching using regex rather than creating all the variations and doing a \array_intersect($webhook->getAttribute('events', []), $events).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants