Feat: Disqus OAuth Provider

[2002Bishwajeet]

What does this PR do?

Adds Disqus OAuth Provider

Test Plan

Manual Testing

Related PRs and Issues

#410

Have you read the Contributing Guidelines on issues?

Yes ✨

[2002Bishwajeet]

Now for some screenshots.

[Meldiron]

@2002Bishwajeet I answered all of your comments and left one new comment. Please address those. Then Ill jump into full code review.

By the way, amazing quality of a PR! 🤩

[Meldiron]

@2002Bishwajeet left code review, just a few small details. Overall looks good 👍 Once they are resolved, I can mark PR as approved.

[Meldiron]

Looks good to me 🥳 Let's please try to make one more account after doing all of these changes to make sure functionality is still untouched.

[Meldiron]

Also please sync with master, looks like there is a conflict with composer.lock. It's a lock file, you can accept all incoming changes (I guess you didn't add any new libraries, nor used any new versions)

[2002Bishwajeet]

I will test it again now

[2002Bishwajeet]

Screenshots time 📸

[Meldiron]

Hmm why is account marked as emailVerified=true? Is this something we do always? @TorstenDittmann probably

[2002Bishwajeet]

any updates?

[stnguyen90]

Hmm why is account marked as emailVerified=true? Is this something we do always? @TorstenDittmann probably

It's hardcoded to true now:

appwrite/app/controllers/api/account.php

Line 484 in e17ab5f

'emailVerification' => true,

but it wasn't before... @TorstenDittmann, do you remember why this change was made?

[TorstenDittmann]

Hmm why is account marked as emailVerified=true? Is this something we do always? @TorstenDittmann probably

It's hardcoded to true now:

appwrite/app/controllers/api/account.php

Line 484 in e17ab5f

'emailVerification' => true,

but it wasn't before... @TorstenDittmann, do you remember why this change was made?

There is a problem with OAuth2 Providers that don't need a verification for the E-Mail and allows you to potentially hijack an account.

Let's say you have an account registered in Appwrite with the e-mail [email protected], now someone else creates a Discord Account using [email protected] and lets say it doesn't need any verification for the E-Mail.

Then this other person can log in to the existing [email protected] account.

So this part reverts that change, since there is a lot of issues with the current implementation.

But it is the first stepstone in our OAuth2 Class to improve this in the future.

[christyjacob4]

Awesome work!

Some minor comments.

• Please reduce the image size from 200x200 to 100x100 as mentioned in the guidelines.

[christyjacob4]

Looks good 👍