Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #30 #31

Closed
wants to merge 12 commits into from
Closed

Fixes: #30 #31

wants to merge 12 commits into from

Conversation

christyjacob4
Copy link
Member

The mistake in the path has been fixed.

@christyjacob4 christyjacob4 reopened this Sep 28, 2019
@christyjacob4 christyjacob4 changed the title Fixes the wrong path in #30 Corrected the Wrong path. fixes #30 Sep 28, 2019
@christyjacob4 christyjacob4 changed the title Corrected the Wrong path. fixes #30 Fixes #30 Sep 28, 2019
@christyjacob4 christyjacob4 changed the title Fixes #30 Fixes: #30 Sep 28, 2019
@eldadfux
Copy link
Member

@christyjacob4 this pull request also includes the Gitlab and Google OAuth adapters, are their ready? Do you want to move them to a separate pull request?

@christyjacob4
Copy link
Member Author

No they aren't ready yet. I just started my work on it.. what do you suggest?

@eldadfux
Copy link
Member

@christyjacob4 Whatever works for you, just let me know when ready and I can start review and merge the changes.

@christyjacob4
Copy link
Member Author

christyjacob4 commented Sep 28, 2019 •
edited
Loading

Is it okay to leave this pull request like this? Or do you want me to remove the oAuth stuff and then raise one more pull request? @eldadfux

@eldadfux
Copy link
Member

You can leave it like this. Just notice, I will only be able to merge this PR once you finish implementing the new OAuth providers because right now they will be shown in the console while they aren't working.

@christyjacob4
Copy link
Member Author

Okay @eldadfux noted :)

@eldadfux eldadfux added bug Something isn't working hacktoberfest Issues that can win you some cool swags! labels Sep 28, 2019
@christyjacob4
Copy link
Member Author

The spelling correction along with the Addition of Google OAuth will be pushed in a new PR. Hence I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest Issues that can win you some cool swags!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christyjacob4 @eldadfux