Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send event when deleting all sessions #3014

Closed
wants to merge 11 commits into from

Conversation

christyjacob4
Copy link
Member

@christyjacob4 christyjacob4 commented Mar 25, 2022

What does this PR do?

  1. return all the sessions as part of realtime payload when deleteAllSessions() is called.
  2. Trigger user events when subscribed to the accounts API
  3. Fix a bug in realtime

Test Plan

Added a new test for the teams.membership.update.status channel

Related PRs and Issues

#2626
#2421
#2469

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Can you add a few tests for events triggered by the Users service?

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christyjacob4 christyjacob4 deleted the fix-realtime-events branch October 4, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants