Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Cannot apply filters with value of 0 in console #6979

Closed
2 tasks done
sierra-hotel opened this issue Oct 22, 2023 · 2 comments · Fixed by appwrite/console#609
Closed
2 tasks done
Assignees
Labels
bug Something isn't working product / console Console, UI and UX issues product / databases Fixes and upgrades for the Appwrite Database.

Comments

@sierra-hotel
Copy link

👟 Reproduction steps

Attempt to add a filter with a value of zero. The "add filter" button will be disabled as shown in this screenshot:

image

👍 Expected behavior

The add filter button should add the filter

👎 Actual Behavior

The add filter button is not clickable. Probably because zero is falsy in Typescript and there is an "if " statement somewhere that should be "if == null"

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@sierra-hotel sierra-hotel added the bug Something isn't working label Oct 22, 2023
@stnguyen90 stnguyen90 added the product / console Console, UI and UX issues label Oct 22, 2023
@stnguyen90
Copy link
Contributor

@sierra-hotel, thanks for creating this! 🙏🏼 you're right, it looks like this is happening because 0 is falsy. While fixing this, we should probably also make sure to allow passing empty string too 🧐

@stnguyen90 stnguyen90 added the product / databases Fixes and upgrades for the Appwrite Database. label Oct 22, 2023
@stnguyen90 stnguyen90 self-assigned this Oct 22, 2023
@nkumawat34
Copy link

I would like to work on this. Can you assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / console Console, UI and UX issues product / databases Fixes and upgrades for the Appwrite Database.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants