Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor filters to be generic #609

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Refactor filters to be generic #609

merged 3 commits into from
Nov 6, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Oct 30, 2023 •
edited
Loading

What does this PR do?

  • Refactor filters so that they can be used on pages other than the documents page.
  • Fix filtering on falsy values
  • Fix filteriing on booleans

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 10:30pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 10:30pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 10:30pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 10:30pm

TGlide
TGlide reviewed Oct 31, 2023
View reviewed changes
src/lib/components/filters/content.svelte Outdated Show resolved Hide resolved
src/lib/components/filters/content.svelte Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@TorstenDittmann TorstenDittmann merged commit 1909f6d into main Nov 6, 2023
6 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-generic-filters branch November 6, 2023 11:25
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@TGlide TGlide TGlide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Cannot apply filters with value of 0 in console
3 participants
@stnguyen90 @TorstenDittmann @TGlide