Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Improve email templates management #6833

Open
2 tasks done
pietrodicaprio opened this issue Oct 6, 2023 · 7 comments
Open
2 tasks done

馃殌 Feature: Improve email templates management #6833

pietrodicaprio opened this issue Oct 6, 2023 · 7 comments
Labels
product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.

Comments

@pietrodicaprio
Copy link

馃敄 Feature description

Right now the email template feature allows the user to replace the body of the global email template:
https://github.com/appwrite/appwrite/blob/main/app/config/locale/templates/email-base.tpl#L59
as (kind of) explained here.

Having the head, CSS and footer fixed in the template it makes hard to keep all the templates aligned overtime if you want to put some extra CSS in order to properly brand the templates because is required to put that CSS in every single template.

馃帳 Pitch

It would be better to allow to customize the head and the footer in separate sections and prepend/append to the body that is handled like it is right now. In this way it's easy to fix/update the CSS of all the templates in once.

image

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@pietrodicaprio
Copy link
Author

pietrodicaprio commented Oct 6, 2023

Me and @mirkobrombin can work on this if it's an accepted feature

It may be good to work on this based on #6495 to avoid overlap/conflicts
The same work could fix #6357

@ItzNotABug
Copy link
Contributor

I'd like to see this as well. This can indeed remove some code duplicacy from the templates.
I'd also suggest a different UI, using something like a <select> which would be more UI friendly for selecting template.

@pietrodicaprio
Copy link
Author

pietrodicaprio commented Oct 7, 2023

I'd like to see this as well. This can indeed remove some code duplicacy from the templates. I'd also suggest a different UI, using something like a <select> which would be more UI friendly for selecting template.

I'm sorry but I don't understand the <select> point: at the moment clicking on the chevron-down it open the accordion for the template. How would you change it?

In the task I would also like to add a wysiwyg editor like Quill (super light) and the possibility to preview the formatted template without needing to call an API to request a password reset (for example). Maybe also add a field text where to insert an email target for sending a test email for a given template?

@ItzNotABug
Copy link
Contributor

@pietrodicaprio Here's a very low level basic idea:

email template settings

This makes the UI less cluttered.


The idea is that you select either the Header, Footer or a Template & the editor opens on the side for that [I might as well make a new Feature Request for this lol].

@pietrodicaprio
Copy link
Author

@pietrodicaprio Here's a very low level basic idea:

Understood, I like it!

Well, as you're a member of the org, how does it work exactly in terms of task execution? Should I just start working on it and open a PR that will eventually be reviewed somewhen or should I wait some confirmation before proceeding?

@ItzNotABug
Copy link
Contributor

@pietrodicaprio A core member will eventually check out the issue, provide feedback if this is something they can move ahead with & assign you the task.

@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label Nov 2, 2023
@nick2432
Copy link

can i work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Development

No branches or pull requests

4 participants