🐛 Bug Report: Broken links in email template

[pietrodicaprio]

👟 Reproduction steps

Send an email like password recovery

👍 Expected behavior

The antispam should not find broken links

👎 Actual Behavior

The two preconnect links at the beginning of the email template are providing 404

appwrite/app/config/locale/templates/email-base.tpl

Lines 5 to 6 in 49155a9

	<link rel="preconnect" href="https://fonts.googleapis.com">
	<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>

This is causing the loss of one point at antispam level

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

MacOS

🧱 Your Environment

Standard AW Cloud environment

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[aakashdeepsil]

Hi team
I want to know more about this issue and get it assigned to me.
I'm participating in the Hacktoberfest and looking to contribute to open source.
I would appreciate all the guidance you can offer.

[pietrodicaprio]

Hi team I want to know more about this issue and get it assigned to me. I'm participating in the Hacktoberfest and looking to contribute to open source. I would appreciate all the guidance you can offer.

Hi @aakashdeepsil , thank you for jumping in and willing to help :)

In my opinion, as external user, the thing to understand is why those two html elements have been added to the template. The quick solution would be to simply remove them but I'm sure that who put them there did it for a reason.
My 2 cents: you can maybe execute a blame on those rows and reach out to the author asking him to comment on this issue

This is the commit that adds those elements: bbf77dc
This is a resource that may provide a solution: https://stackoverflow.com/a/56845961/4193164

[aakashdeepsil]

@pietrodicaprio To me, the reproduction steps aren't very clear. Sorry if it's a dumb question. It's my first time working in open-source. I will like more detailed steps to reproduce this issue. It will help me understand the problem better. Appreciate the help.

[OgunmisiM]

Best thing to do to the link is to remove them.
I can help with that.

[pietrodicaprio]

Guys, I really appreciate your willing to help but I'm able to simply remove the links and open a PR.
Moreover not having the "reproduction steps clear" is symptom of not knowing the product/project. In my opintion, wanting to rush on a solution just to participate to the hackaton/hacktober fest is not the correct method to help.

The point is: why have been added in the first place?
The question is mainly for @lohanidamodar that made the commit for the new templates.

Should we modify those two preconnect links as suggested in the Stackoverflow answer I linked? Was that the original idea? It could work for the fonts.googleapis.com but there is no "working link" for fonts.gstatic.com. Could it be better to import the font in the CSS section of the template via @import directive?

[aakashdeepsil]

@pietrodicaprio I understand and appreciate your feedback. Can you please guide me and help to know the product/project? Where and how should I get to know it better?