Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth provider String to Enum #426

Closed
drandell opened this issue Jun 18, 2020 · 4 comments · Fixed by #5726
Closed

OAuth provider String to Enum #426

drandell opened this issue Jun 18, 2020 · 4 comments · Fixed by #5726
Labels
enhancement New feature or request waiting for release Fixed or implemented and waiting for a new version to be released

Comments

@drandell
Copy link
Contributor

Current 0Auth providers are strings.
Appwrite should define an enum with all the allowed providers for each of use.

Existing flutter example;

return await account.createOAuth2Session(provider: 'facebook');

Proposed improvment;

return await account.createOAuth2Session(provider: Provider.Facebook);
@eldadfux
Copy link
Member

Actually this could be useful to any of the API params that are using the Whitelist validator:
https://appwrite.io/docs/client/avatars?sdk=web#getCreditCard
https://appwrite.io/docs/client/avatars#getBrowser
https://appwrite.io/docs/client/avatars#getFlag
and more...

@eldadfux eldadfux added the enhancement New feature or request label Jun 18, 2020
@drandell
Copy link
Contributor Author

Agree 100%, didn't know about those other endpoints. I find strings are so easily misspelled / small typo from an accidental elbow on the keyboard etc. :D

@TorstenDittmann TorstenDittmann mentioned this issue Apr 6, 2021
Closed
@TorstenDittmann TorstenDittmann added this to To do in 0.9.x via automation Jun 25, 2021
@TorstenDittmann TorstenDittmann removed this from To do in 0.9.x Jul 2, 2021
@TorstenDittmann TorstenDittmann added this to To do in 0.10.x via automation Jul 2, 2021
@Lucke0051 Lucke0051 mentioned this issue Jan 15, 2022
Closed
@eldadfux eldadfux removed this from To do in 0.10.x Jan 15, 2022
@tanmoy27112000
Copy link

@eldadfux @TorstenDittmann I would like to work on this

@stnguyen90 stnguyen90 mentioned this issue Apr 7, 2023
Closed
2 tasks
@ItzNotABug ItzNotABug mentioned this issue Apr 7, 2023
Closed
2 tasks
This was referenced Jun 19, 2023
Merged
Merged
@eldadfux
Copy link
Member

4 years in and we got some EXCITING news! This feature is going to make it for Appwrite 1.5!

@eldadfux eldadfux added the waiting for release Fixed or implemented and waiting for a new version to be released label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request waiting for release Fixed or implemented and waiting for a new version to be released
Projects
1.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Whitelist enums 2002Bishwajeet/appwrite
4 participants
@drandell @eldadfux @stnguyen90 @tanmoy27112000