-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug Report: Wrong signature for createMembership server side implementation #5676
Comments
Interesting. @stnguyen90 The order of params in the specs match the order we input the params in the controller yah? Sounds like we just need to update the order. |
@byawitz Thanks for brining this up! |
I'm trying to use the server side sdk to create a team membership. But I get this error:
But the docs don't mention anything about It accepts empty string but not |
Which version are you running and which version of the docs are you looking at ;) |
👟 Reproduction steps
createMembership()
function doesn't match the function signature,https://appwrite.io/docs/server/teams?sdk=nodejs-default#teamsCreateMembership
In languages that utilize named parameters, it's not that of a problem, But in others, it can cause confusion.
So this will become like this
👍 Expected behavior
Order in the docs and in the function should match.
👎 Actual Behavior
The order doesn't match and prioritizes optional fields over required ones.
🎲 Appwrite version
Version 1.3.x
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: