Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Omit the requirement of the URL parameter in server createMembership function #5675

Closed
2 tasks done
byawitz opened this issue Jun 7, 2023 · 4 comments
Closed
2 tasks done
Assignees
Labels
product / functions Fixes and upgrades for the Appwrite Functions.

Comments

@byawitz
Copy link
Member

byawitz commented Jun 7, 2023

馃敄 Feature description

From the docs

Invite a new member to join your team. Provide an ID for existing users, or invite unregistered users using an email or phone number. If initiated from a Client SDK, Appwrite will send an email or sms with a link to join the team to the invited user, and an account will be created for them if one doesn't exist. If initiated from a Server SDK, the new member will be added automatically to the team.

When using the teams createMembership() function in a Server side SDK it seems like there's no need for the URL parameter, or at least it shouldn't be required.

馃帳 Pitch

As no email is being sent then no need for the url parameter.

P.s. maybe it can work that if the user is adding url to the server side function, then it will send email even from the server side implementation. but that's already another feature.

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@joeyouss
Copy link

Thank you for opening this. Currently, the URL parameter plays a crucial role in safeguarding against possible open redirect attacks, particularly when involving user API interactions. If we were to remove this parameter, it would require careful internal handling, as other adjustments would likely need to be made as well.
I will keep this feature request open for future consideration and gathering feedback.

@joeyouss joeyouss self-assigned this Jun 14, 2023
@joeyouss joeyouss added product / functions Fixes and upgrades for the Appwrite Functions. feature labels Jun 14, 2023
@byawitz
Copy link
Member Author

byawitz commented Jun 14, 2023

I've meant with Server side SDKs, in which the URL parameter is not in use.

@joeyouss
Copy link

Yes, I am talking about them as well

@stnguyen90
Copy link
Contributor

Closing as url is no longer required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / functions Fixes and upgrades for the Appwrite Functions.
Projects
None yet
Development

No branches or pull requests

3 participants