Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Dynamic state in OAuth2 #5520

Open
2 tasks done
gepd opened this issue May 10, 2023 · 2 comments
Open
2 tasks done

馃殌 Feature: Dynamic state in OAuth2 #5520

gepd opened this issue May 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.

Comments

@gepd
Copy link
Contributor

gepd commented May 10, 2023

馃敄 Feature description

Would great to have an option to work with dynamic state in OAuth2

馃帳 Pitch

In my case my provider has a requirement to have a dynamic state to use its oauth2 authentication (its a private one).

Stateless have the benefit to avoid to re-type your credentials again. But when you have sensitive data, if you close your session is essential to identificate the user again.

Currently if you close your session and log in again the session will be create again without ask for any credentials

Talking with Steven: https://discord.com/channels/564160730845151244/1105607724575768607 we agree the hard part is to maintain the state and validate it

I open this issue to discuss about it

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@stnguyen90
Copy link
Contributor

@gepd, thanks for creating this issue! 馃檹馃徏

In my case my provider has a requirement to have a dynamic state to use its oauth2 authentication (its a private one).

What you're describing isn't specific to your provider. This is a standard part of OAuth2. See this. This is something that would be nice to have in Appwrite.

Currently if you close your session and log in again the session will be create again without ask for any credentials

This is expected because the user still has a session with the OAuth2 provider and the user has already granted Appwrite access to the account. Some providers allow passing some additional parameters to tweak the behavior. For example, prompt=login or prompt=select_account.

@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label May 10, 2023
@joeyouss joeyouss self-assigned this May 19, 2023
@joeyouss joeyouss added the enhancement New feature or request label May 19, 2023
@joeyouss
Copy link

Hi @gepd - if no further help is needed, can you please close the issue?

vaibhavagarwal220 added a commit to vaibhavagarwal220/appwrite that referenced this issue Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
None yet
Development

No branches or pull requests

3 participants