feat: Geolocation APIs on appsmith #9295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unable to find test scripts. Please add necessary tests to the PR. |
1 similar comment
|
Unable to find test scripts. Please add necessary tests to the PR. |
|
Unable to find test scripts. Please add necessary tests to the PR. |
|
/ok-to-test sha=d99d133 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1493827808. |
eco-monk
reviewed
Nov 25, 2021
|
/ok-to-test sha=2fad65b |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1519808407. |
eco-monk
reviewed
Nov 30, 2021
app/client/src/components/editorComponents/ActionCreator/index.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Anand Srinivasan <[email protected]>
eco-monk
previously approved these changes
Nov 30, 2021
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1519808407. |
eco-monk
previously approved these changes
Dec 7, 2021
|
/ok-to-test sha=d36c9ce |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1548081116. |
7 tasks
7 tasks
7 tasks
mohanarpit
pushed a commit
that referenced
this pull request
Oct 20, 2022
## Description **Revert Context -** Reverts #14890 (We had to revert the PR as we got some suggestions on improving the feature - now reverting the revert so we can have this feature out with improvements) **PR Context -** This pull request exposes window.postMessage() as a global function in the Appsmith platform. Post message safely enables cross-origin communication between window objects. Example use-case - Appsmith page embedded within an iframe which communicates with the container website Diagram for all the different levels of communication -  **More on post message here** - https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage **References used for this PR:** 1. Geolocation APIs - #9295 2. setInterval and clearInterval support - #8158 **Fixes** #7241 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Test plan - **Manual**: Created an app with different buttons holding different types of data and embedded it in a code sandbox within an iframe. Also removed the target origin which throws an error (App link - https://dev.appsmith.com/app/post-msg-app/page1-624c1af4d8e632741017682e, Codesandbox link - https://codesandbox.io/s/compassionate-tdd-6dnzzd?file=/src/index.js) - Added Jest tests - https://github.com/appsmithorg/TestSmith/issues/1892 - https://github.com/appsmithorg/TestSmith/issues/2068 - https://github.com/appsmithorg/TestSmith/issues/2069 - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes Co-authored-by: Aishwarya UR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose Geolocation apis to appsmith app developers
Fixes #9207
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased