Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add escaping special characters before JSON.parse #9293

Merged
merged 8 commits into from
Nov 25, 2021
Merged

fix: Add escaping special characters before JSON.parse #9293

merged 8 commits into from
Nov 25, 2021

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Nov 23, 2021 •
edited by github-actions bot
Loading

Description

Fixes ( #8802 )

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: fix/escape-spl-chars
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.05 (0.01) 36.94 (0) 33.79 (0.01) 55.53 (0.01)
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.04 (-0.22) 40.42 (-0.83) 34.48 (0) 55.96 (-0.26)
🟢 app/client/src/widgets/WidgetUtils.ts 84.31 (0.98) 59.38 (0) 54.55 (4.55) 80.49 (1)
🔴 app/client/src/widgets/ListWidget/widget/index.tsx 61.69 (-0.3) 26.15 (0) 56 (0) 60.51 (-0.3)

@rishabhrathod01 rishabhrathod01 linked an issue Nov 23, 2021 that may be closed by this pull request
[Bug]: Action fails when params have EOF characters inside them #8802
Closed
1 task
@rishabhrathod01 rishabhrathod01 added the FE Coders Pod Issues related to users writing javascript in appsmith label Nov 23, 2021
@rishabhrathod01 rishabhrathod01 self-assigned this Nov 23, 2021
@github-actions github-actions bot added the Bug Something isn't working label Nov 23, 2021
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=9ecb752

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1493718612.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9ecb752.
PR: 9293.

@rishabhrathod01 rishabhrathod01 marked this pull request as ready for review November 23, 2021 07:43
@rishabhrathod01
Copy link
Contributor Author

rishabhrathod01 commented Nov 23, 2021 •
edited
Loading

/ok-to-test sha=9ecb752

1 similar comment
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=9ecb752

@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=090a31b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1499037823.
Workflow: Appsmith External Integration Test Workflow.
Commit: 090a31b.
PR: 9293.

@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=83cdc82

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1503073450.
Workflow: Appsmith External Integration Test Workflow.
Commit: 83cdc82.
PR: 9293.

@rishabhrathod01 rishabhrathod01 merged commit d7cdf6f into release Nov 25, 2021
@rishabhrathod01 rishabhrathod01 deleted the fix/escape-spl-chars branch November 25, 2021 10:52
nayan-rafiq pushed a commit that referenced this pull request Dec 8, 2021
@rishabhrathod01
fix: Add escaping special characters before JSON.parse (#9293)
14aeb3e 
* Add escaping special characters before JSON.parse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

@hetunandu hetunandu Awaiting requested review from hetunandu

Assignees

@rishabhrathod01 rishabhrathod01

Labels
Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Action fails when params have EOF characters inside them
2 participants
@rishabhrathod01 @jsartisan