Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearInterval action creator adds argument in the wrong slot #9029

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Nov 8, 2021

Description

using the clearInterval action creator function id field would add the argument in the wrong slot. This PR will fix the field

Fixes #8643

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/clearIntervalActionCreator 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.59 (0.02) 36.44 (0) 33.21 (0) 55.12 (0.03)
🟢 app/client/src/components/editorComponents/ActionCreator/Fields.tsx 31.93 (5.6) 22.16 (0.86) 7.79 (1.03) 31.38 (5.87)
🔴 app/client/src/components/editorComponents/ActionCreator/index.tsx 40.54 (-0.2) 6.84 (0.23) 40 (0) 40.44 (-0.2)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.04 (-0.22) 40.42 (-0.83) 34.48 (0) 55.96 (-0.26)

@github-actions github-actions bot added the Bug Something isn't working label Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Unable to find test scripts. Please add necessary tests to the PR.

rishabhrathod01
rishabhrathod01 previously approved these changes Nov 8, 2021
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetunandu
Copy link
Member Author

/ok-to-test sha=7bacaa2

@hetunandu
Copy link
Member Author

/ok-to-test sha=689b5bc

@hetunandu
Copy link
Member Author

/ok-to-test sha=1a46834

@hetunandu
Copy link
Member Author

/ok-to-test sha=f2ca8a6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1452012037.
Workflow: Appsmith External Integration Test Workflow.
Commit: f2ca8a6.
PR: 9029.

1 similar comment
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1452012037.
Workflow: Appsmith External Integration Test Workflow.
Commit: f2ca8a6.
PR: 9029.

@hetunandu
Copy link
Member Author

/ok-to-test sha=f2ca8a6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1460465312.
Workflow: Appsmith External Integration Test Workflow.
Commit: f2ca8a6.
PR: 9029.

1 similar comment
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1460465312.
Workflow: Appsmith External Integration Test Workflow.
Commit: f2ca8a6.
PR: 9029.

Copy link
Contributor

@rishabhrathod01 rishabhrathod01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hetunandu hetunandu merged commit 429337b into release Nov 16, 2021
@hetunandu hetunandu deleted the fix/clearIntervalActionCreator branch November 16, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: setting Id in clearInterval with input fields creates syntax error
2 participants