Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Data clone error when returning results from trigger event #8673

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix: Data clone error when returning results from trigger event #8673

merged 1 commit into from
Oct 26, 2021

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Oct 21, 2021 •
edited by github-actions bot
Loading

Description

Fixes #7909
Fixes #7673

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/data-clone-error
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.86 (-0.01) 36.56 (-0.01) 33.61 (0) 55.39 (0)
🔴 app/client/src/selectors/commentsSelectors.ts 85.25 (-1.64) 63.24 (-2.94) 76.67 (0) 88.24 (-2.35)

@github-actions github-actions bot added the Bug Something isn't working label Oct 21, 2021
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@hetunandu
Copy link
Member Author

/ok-to-test sha=9cf088b

@mohanarpit mohanarpit merged commit e6b0f4d into release Oct 26, 2021
@mohanarpit mohanarpit deleted the fix/data-clone-error branch October 26, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApekshaBhosale ApekshaBhosale ApekshaBhosale approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@hetunandu @ApekshaBhosale @mohanarpit