Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check to confirm variable are string #8358

Merged
merged 3 commits into from
Oct 18, 2021
Merged

fix: Add check to confirm variable are string #8358

merged 3 commits into from
Oct 18, 2021

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Oct 8, 2021 •
edited by github-actions bot
Loading

Description

Fixes #8265

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: hotfix/typeError
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.93 (0) 36.64 (0.01) 33.89 (0) 55.47 (-0.01)
🔴 app/client/src/components/editorComponents/GlobalSearch/index.tsx 52.13 (-0.35) 14.62 (0.22) 37.31 (0) 53.65 (-0.39)

@rishabhrathod01 rishabhrathod01 linked an issue Oct 8, 2021 that may be closed by this pull request
[Bug] TypeError: t.toLowerCase is not a function #8265
Closed
@rishabhrathod01 rishabhrathod01 changed the title hotfix: Add check to confirm variable are string fix: Add check to confirm variable are string Oct 8, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 8, 2021
@rishabhrathod01 rishabhrathod01 enabled auto-merge (squash) October 12, 2021 11:47
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=b0a24ab

@rishabhrathod01 rishabhrathod01 merged commit 6693c62 into release Oct 18, 2021
@rishabhrathod01 rishabhrathod01 deleted the hotfix/typeError branch October 18, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhsaxena rishabhsaxena rishabhsaxena approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] TypeError: t.toLowerCase is not a function
2 participants
@rishabhrathod01 @rishabhsaxena