Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css issue with new DS changes #8181

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Oct 4, 2021

Description

Saw issue with UnsupportedPluginDialog.tsx UI after new DS changes, this PR fixes those css issue

Screenshot 2021-10-05 at 2 34 22 AM

After Fix

Screenshot 2021-10-05 at 3 13 59 AM

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/unsupported_plugin_dialog_ui 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.95 (0) 36.68 (0.01) 33.87 (0) 55.52 (0.01)
🟢 app/client/src/pages/Editor/IntegrationEditor/UnsupportedPluginDialog.tsx 52.27 (1.16) 100 (0) 0 (0) 54.76 (1.27)
🟢 app/client/src/selectors/commentsSelectors.ts 79.84 (1.61) 57.35 (2.94) 70 (0) 86.36 (2.27)

@rishabhrathod01 rishabhrathod01 changed the title Fix css issue with new DS changes fix: css issue with new DS changes Oct 4, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 4, 2021
@rishabhrathod01 rishabhrathod01 self-assigned this Oct 4, 2021
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=32d85eb

@rishabhrathod01 rishabhrathod01 merged commit 4fde9d6 into release Oct 8, 2021
@rishabhrathod01 rishabhrathod01 deleted the fix/unsupported_plugin_dialog_ui branch October 8, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants