Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: js action parsing error resolution #8086

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Oct 1, 2021

Description

Hotfix for resolution parsing error putting the app in the unrecoverable state

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: hotfix/js-action-parsing-error 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.79 (0) 36.94 (0.01) 33.81 (0) 55.41 (0)
🟢 app/client/src/selectors/commentsSelectors.ts 79.84 (1.61) 57.35 (2.94) 70 (0) 86.36 (2.27)
🔴 app/client/src/workers/evaluate.ts 89.66 (-1.04) 75 (-6.82) 80 (0) 89.41 (-1.07)

@nidhi-nair nidhi-nair changed the title hotfix: js action parsing error resolution fix: js action parsing error resolution Oct 1, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 1, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal merged commit 79aefc4 into release Oct 1, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal deleted the hotfix/js-action-parsing-error branch October 1, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants