Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue when form crashes after copy or move of mongo query #7750

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Sep 23, 2021

Description

Bad URL construction was causing the mongo query to crash after move or copy

Fixes #7743

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual steps:

Create a mongo query and copy/move it to another page

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/action-config-children-error 
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/sagas/QueryPaneSagas.ts 24.11 (0.22) 11.63 (0) 25 (0) 27.96 (0.3)

@github-actions github-actions bot added the Bug Something isn't working label Sep 23, 2021
@hetunandu hetunandu enabled auto-merge (squash) September 23, 2021 11:20
@hetunandu hetunandu merged commit d18d781 into release Sep 23, 2021
@hetunandu hetunandu deleted the fix/action-config-children-error branch September 23, 2021 11:35
gaurav-batra-couture pushed a commit to gaurav-batra-couture/appsmith that referenced this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TypeError: Cannot read properties of undefined (reading 'map')
2 participants